Use max_by for longest_cmd_name_length
#628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
reviewed
Jul 4, 2023
lib/irb/cmd/show_cmds.rb
Outdated
| @@ -14,7 +14,7 @@ class ShowCmds < Nop | |||
| def execute(*args) | |||
| commands_info = IRB::ExtendCommandBundle.all_commands_info | |||
| commands_grouped_by_categories = commands_info.group_by { |cmd| cmd[:category] } | |||
| longest_cmd_name_length = commands_info.map { |c| c[:display_name] }.max { |a, b| a.length <=> b.length }.length | |||
| longest_cmd_name_length = commands_info.map { |c| c[:display_name] }.max_by(&:length).length | |||
There was a problem hiding this comment.
How about
map { |c| c[:display_name] }.map(&:length).max
or
map { |c| c[:display_name].length }.max
There was a problem hiding this comment.
Nice, I've pushed an update.
andyw8
force-pushed
the
andyw8/use-max-by-for-longest_cmd_name_length
branch
from
96944b6
to
f17b038
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jul 4, 2023
(ruby/irb#628) ruby/irb@5e87f3bfdd Co-authored-by: Andy Waite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small refactoring for readability.
https://rubyapi.org/3.2/o/enumerable#method-i-max_by